Fix package resource assign bug for jar manifests #3983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyanSinhaMahapatra
force-pushed
the
jar-manifest-assign-package
branch
from
02859cf
to
cb808a2
Compare
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra
force-pushed
the
jar-manifest-assign-package
branch
from
cb808a2
to
d7fc4cc
Compare
pombredanne
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
This can be merged in the meantime but the larger issue of JAR as a PURL type tracked in #3962 will need some love soon, may be with an "unknown" PURL type
| @@ -1199,6 +1199,12 @@ def assign_package_to_resources(cls, package, resource, codebase, package_adder= | |||
| # NOTE: we do not attach files to the Package level. Instead we | |||
| # update `for_packages` of a codebase resource. | |||
| package_uid = package.package_uid | |||
| if resource.path.endswith("-extract"): | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a bug in scancode.io Java
MANIFEST.MFparsing and while scanning jars withscan_codebasepipelines we were not assigning package resources to DiscoveredPackages correctly. This PR fixes the same.Tasks
Run tests locally to check for errors.