Skip to content

Conversation

@pombredanne
Copy link
Member

Add new rules with URLs.

Fixes #3973

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pombredanne thanks!

We need to add required phrases + skip_for_required_phrase_generation, or a high minimum coverage for these.

@pombredanne
Copy link
Member Author

@AyanSinhaMahapatra re:

We need to add required phrases + skip_for_required_phrase_generation, or a high minimum coverage for these.

I made these required phrases and fxied the DCO... but in all cases since these are only URLs they would come with a 100% minimum coverage for free:

@pombredanne
Copy link
Member Author

and I rebased.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne pombredanne merged commit 59535d7 into develop Apr 21, 2025
43 checks passed
@pombredanne pombredanne deleted the autosar-rules branch April 21, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add AUTOSAR proprietary notice

2 participants