Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After creating a conclusion, JSTree selector should not re-select the root node #372

Closed
steven-esser opened this issue May 21, 2019 · 1 comment
Closed

After creating a conclusion, JSTree selector should not re-select the root node #372

steven-esser opened this issue May 21, 2019 · 1 comment
Assignees
@steven-esser
Labels
bug jstree ui
Milestone
Release v3.1.1

Comments

@steven-esser
Copy link
Contributor

After creating a conclusion at some arbitrary file or directory, the JSTree selection should not change. Currently, after making and saving a conclusion, the JSTree selects the top-level root node instead of the file/directory that the conclusion was made for.

This is problematic with large scans, as selecting the root node while on one of the dashboard views causes the whole view to update to the root node which may contain lots of info.
@steven-esser steven-esser added this to the Future milestone May 21, 2019
@steven-esser steven-esser self-assigned this May 21, 2019
steven-esser added a commit that referenced this issue May 22, 2019
@steven-esser
Do not select root node on JSTree refresh
ea896b6 
Addresses: #372

Signed-off-by: Steven Esser <sesser@nexb.com>
@steven-esser
Copy link
Contributor Author

#373 merged, closing this.

steven-esser added a commit that referenced this issue Jul 11, 2019
@steven-esser
Do not select root node on JSTree refresh
9c97219 
Addresses: #372

Signed-off-by: Steven Esser <sesser@nexb.com>
steven-esser added a commit that referenced this issue Jul 11, 2019
@steven-esser
Do not select root node on JSTree refresh
c4892c6 
Addresses: #372

Signed-off-by: Steven Esser <sesser@nexb.com>
@steven-esser steven-esser modified the milestones: Future, Release v3.1.1 Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@steven-esser steven-esser

Labels
bug jstree ui
Projects
None yet
Milestone
Release v3.1.1
Development

No branches or pull requests
1 participant
@steven-esser