Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to display the API Key value in the "Upload Conclusions" form #391

Closed
tdruez opened this issue Sep 19, 2019 · 2 comments
Closed

Ability to display the API Key value in the "Upload Conclusions" form #391

tdruez opened this issue Sep 19, 2019 · 2 comments
Assignees
@steven-esser
Labels
enhancement must have
Milestone
Release v3.1.1

Comments

@tdruez
Copy link

tdruez commented Sep 19, 2019

The "DejaCode API Key" field in the "Upload Conclusions" form is always hidden. In order to double check the pasted value, it would be very useful to offer a "Display/Hide" toggle button, while keeping that value hidden by default.

Also, since the API Key never starts nor ends with a whitespace, it would be a good idea to "strip" leading and trailing whitespaces before making the API request. The would help with some copy/paste issues.
steven-esser added a commit that referenced this issue Sep 23, 2019
@steven-esser
Improve Conclusion uploads
c2aa53b 
* Add button to toggle DejaCode API key visibility
* Trim leading and trailing spaces from DejaCode API key
* Allow empty Product Version in DejaCode upload form
* Fix npm vulns via `npm audit`

Addresses: #391, #392

Signed-off-by: Steven Esser <sesser@nexb.com>
steven-esser added a commit that referenced this issue Sep 23, 2019
@steven-esser
Improve Conclusion uploads
86700b7 
* Add button to toggle DejaCode API key visibility
* Trim leading and trailing spaces from DejaCode API key
* Allow empty Product Version in DejaCode upload form
* Fix npm vulns via `npm audit`

Addresses: #391, #392

Signed-off-by: Steven Esser <sesser@nexb.com>
@steven-esser steven-esser mentioned this issue Sep 23, 2019
Merged
steven-esser added a commit that referenced this issue Sep 23, 2019
@steven-esser
Improve Conclusion uploads
df25f0c 
* Add button to toggle DejaCode API key visibility
* Trim leading and trailing spaces from DejaCode API key
* Allow empty Product Version in DejaCode upload form
* Fix npm vulns via `npm audit`

Addresses: #391, #392

Signed-off-by: Steven Esser <sesser@nexb.com>
@steven-esser steven-esser added this to the v 3.1.1 milestone Sep 23, 2019
@steven-esser
Copy link
Contributor

@tdruez The fix for this is merged in #394. I will leave this issue open until the next patch release of the workbench.

@steven-esser
Copy link
Contributor

Patch release v3.1.1 of scancode-workbench is released and contains these fixes. Closing this ticket.

@mjherzog mjherzog mentioned this issue Dec 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@steven-esser steven-esser

Labels
enhancement must have
Projects
None yet
Milestone
Release v3.1.1
Development

No branches or pull requests
2 participants
@tdruez @steven-esser