Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new resolved_to field on DiscoveredDependency #1066 #1240

Merged
merged 5 commits into from
May 17, 2024

Conversation

tdruez
Copy link
Contributor

@tdruez tdruez commented May 17, 2024

And refine existing fields of the model

tdruez added 4 commits May 17, 2024 11:32
And refine existing fields of the model

Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
Signed-off-by: tdruez <tdruez@nexb.com>
DiscoveredPackage,
related_name="resolved_dependencies",
help_text=_(
"The package that this dependency resolves to. "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"The package that this dependency resolves to. "
"The resolved package for this dependency. "

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!
@Hritik14 this is essentially a smaller version of #896 ... Feedback welcomed!
There ares still things in #896 that we could merge afterwards, but I feel the PR here is smaller and more focused, easier to merge.

Signed-off-by: tdruez <tdruez@nexb.com>
@tdruez tdruez merged commit dcb4e5e into main May 17, 2024
9 checks passed
@tdruez tdruez deleted the 1066-dependency-resolve-to branch May 17, 2024 14:20
@tdruez tdruez mentioned this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants