Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyproject.toml for packaging aboutcode.pipeline module #1351 #1359

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

tdruez
Copy link
Contributor

@tdruez tdruez commented Aug 8, 2024

The dist archives can be manually built with:

$ cd scancode.io
$ source .venv/bin/activate
$ pip install flot
$ flot --pyproject pipeline-pyproject.toml --sdist --wheel --output-dir dist/

Also, regarding #1358 (comment), it seems that using the aboutcode.pipeline works fine:

pip install aboutcode.pipeline --find-links=scancode.io/dist --no-index --no-cache-dir
# Successfully installed aboutcode.pipeline-0.1

pip install aboutcode_pipeline --find-links=scancode.io/dist --no-index --no-cache-dir
# Successfully installed aboutcode_pipeline-0.1

pip install aboutcode-pipeline --find-links=scancode.io/dist --no-index --no-cache-dir
# Successfully installed aboutcode-pipeline-0.1

@keshav-space could you adapt and add the pypi-release-abc-pipeline.yml (let's use pypi-release-aboutcode-pipeline.yml) from https://github.com/nexB/scancode.io/pull/1332/files#diff-bbcc61089df1f0d385697aff0c2da0e9c972d8cf73acfe27f8cb437df2e92b46

Let's make sure we have a separate tag convention to trigger the releases of aboutcode.pipeline independently of the ScanCode.io releases.

This is fixes #1351

tdruez and others added 3 commits August 8, 2024 19:38
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space
Copy link
Member

@tdruez, I've added the workflow to publish aboutcode.pipeline on PyPI, i've commented out the automatic trigger since we want to do the release manually.

Signed-off-by: tdruez <tdruez@nexb.com>
@tdruez
Copy link
Contributor Author

tdruez commented Aug 9, 2024

@keshav-space I've enabled the automatic build/publish on tag. I've removed the release addition in GH though, not sure we want to put those releases there.

@tdruez tdruez merged commit ceb345e into main Aug 9, 2024
9 checks passed
@tdruez tdruez deleted the 1351-aboutcode-pipeline-packaging branch August 9, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

Extract base pipeline code for reuse in other projects
3 participants