Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the group decorator for pipeline steps as optional_step #1442

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

tdruez
Copy link
Contributor

@tdruez tdruez commented Nov 7, 2024

#1426

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Copy link
Member

@tdruez I've fixed the tests by adding explicit options for pipeline integration tests and updated some docs too.
This is probably much cleaner and faster than (changing instances in code is probably not required as most of these are not user facing anyway) the approach at 5507228#diff-4b8ad9b60fea03b9d86372b709ec186cf84bfb260e215d2f31c688fa3991d3bfL274 so this makes much more sense.

Thanks and this is ready for your review.

@AyanSinhaMahapatra AyanSinhaMahapatra linked an issue Nov 12, 2024 that may be closed by this pull request
@tdruez tdruez merged commit 8251767 into main Nov 21, 2024
9 checks passed
@tdruez tdruez deleted the 1426-optional-step branch November 21, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding projects through the API runs all groups
2 participants