Do not fail project on memory spikes #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdruez
reviewed
Jan 6, 2025
There was a problem hiding this comment.
@AyanSinhaMahapatra Why not use resource.project instead of adding a new argument?
|
@tdruez good point, I did not remember that we could reach the project through the resource. Let me update this to use |
We have an unresolved issued of multi-gigabyte memory spikes when scanning files for licenses in some rare cases, like it is reported at aboutcode-org/scancode-toolkit#3711 Currently we fail the project on encountering such memory spikes, but we don't get any scan info from the rest of the project because we raise the Exception. This adds a project error instead of raising an Exception, so we can continue scanning the rest of the resources. Reference: aboutcode-org/scancode-toolkit#3711 Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra
force-pushed
the
fix-memory-spike
branch
from
04244b5 to
df84f50
Compare
AyanSinhaMahapatra
added a commit
that referenced
this pull request
Jan 6, 2025
Ignore scanning large data files which are larger than 1 MB to avoid crashing scans on memory spikes. Also rollback #1504 Reference: aboutcode-org/scancode-toolkit#3711 Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra
added a commit
that referenced
this pull request
Jan 6, 2025
Ignore scanning large data files which are larger than 1 MB to avoid crashing scans on memory spikes. Also rollback #1504 Reference: aboutcode-org/scancode-toolkit#3711 Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra
added a commit
that referenced
this pull request
Jan 6, 2025
Ignore scanning large data files which are larger than 1 MB to avoid crashing scans on memory spikes. Also rollback #1504 Reference: aboutcode-org/scancode-toolkit#3711 Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
tdruez
added a commit
that referenced
this pull request
Jan 21, 2025
* Ignore scanning large data files Ignore scanning large data files which are larger than 1 MB to avoid crashing scans on memory spikes. Also rollback #1504 Reference: aboutcode-org/scancode-toolkit#3711 Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com> * Bump scancode-toolkit to version v32.3.1 Also remove platform constraints from rust-inspector and go-inspector. Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com> * Increase size limit to skip scanning data file Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com> * Add a scancodeio setting SCANCODEIO_SCAN_MAX_FILE_SIZE Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com> * Use scancode with conda bugfix Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com> * Address feedback Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com> * Bump scancode-toolkit to v32.3.2 Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com> * Add scan_max_file_size to project settings Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com> * Update CHANGELOG and docs on project settings Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com> * Add scan_max_file_size to project settings UI Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com> --------- Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com> Co-authored-by: tdruez <tdruez@nexb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an unresolved issued of multi-gigabyte memory spikes when scanning files for licenses in some rare cases, like it is reported at aboutcode-org/scancode-toolkit#3711 Currently we fail the project on encountering such memory spikes, but we don't get any scan info from the rest of the project because we raise the Exception. This adds a project error instead of raising an Exception, so we can continue scanning the rest of the resources.
Reference: aboutcode-org/scancode-toolkit#3711