changing tool_name from scanpipe to ScanCode.io #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyanSinhaMahapatra
requested changes
Feb 20, 2025
There was a problem hiding this comment.
@Avan2021 thanks for your PR.
- Could you merge the latest main branch, we had a lot of CI tests failing from an unrelated issue (see Bump commoncode to v32.2.0 and pin BeautifulSoup4 #1583 (comment)) so you need to use the latest which has the fix. You would still have some test failures after this btw, you need to fix those.
- You have merely changed the test expectations which are the JSON files, but you have not changed the actual behavior where the scan results JSON has the correct
tool_name. Can you look at the code inscanpipe/pipes/output.pywhere we set thetool_nameand modify it accordingly?
Signed-off-by: Avan2021 <avandalal2007@gmail.com>
Signed-off-by: Avan2021 <avandalal2007@gmail.com>
|
Hi @AyanSinhaMahapatra, I am sorry for not seeing the comments or email. I was occupied by something, thanks for pointing out that I also need to have change tool_name accessed by the output.py |
AyanSinhaMahapatra
requested changes
Mar 11, 2025
There was a problem hiding this comment.
@Avan2021 please check the test failures, you should always run the tests locally before pushing. There is some more changes required here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1556
Replaced all instances of
tool_namefromscanpipetoScanCode.io