Bug in vulnerability details view

[TG1999]

[johnmhoran]

@TG1999 Can you please describe the bug?

[TG1999]

The border on the first table in the page is missing.

[johnmhoran]

This -- from the public VCIO -- already has a border.

[TG1999]

@johnmhoran if you will check main branch, it does not have a border

[johnmhoran]

So you're saying that the current public VCIO has the border but the main branch does not?

[TG1999]

Yes!

[johnmhoran]

OK, noted, will add to my list of issues to tackle when I get to working on the vulnerability UI/API.

[johnmhoran]

But I would like us to fix the dupe PURL issue and the search/lookup issue we've been discussing as well -- these are implicated in the number and characteristics of packages returned from a search in the UI/API and thus directly impact my planned consolidation in the vuln details view of the affected packages-fixed by packages tabs. Can we do that?

[TG1999]

But I would like us to fix the dupe PURL issue and the search/lookup issue we've been discussing as well -- these are implicated in the number and characteristics of packages returned from a search in the UI/API and thus directly impact my planned consolidation in the vuln details view of the affected packages-fixed by packages tabs. Can we do that?

@johnmhoran that's in progress here https://github.com/nexB/vulnerablecode/tree/package-purl-model-updates

[TG1999]

OK, noted, will add to my list of issues to tackle when I get to working on the vulnerability UI/API.

Alright, FYI this may be a deployment blocker.

[johnmhoran]

@TG1999 Hmm. I just checked out main locally, without any current pull (in log last item is your Nov 27 Prepare for release v33.6.3 (#1348) commit), and the table has a border. I'll do a git pull and see how it looks.

[johnmhoran]

In main, after a git pull, ran make run and ... there's a border. Perhaps I missed a step, e.g., after doing git pull in main and before make run?

[johnmhoran]

@TG1999 My prior screenshots were in Chrome. But in Firefox, I can no longer see that table's border!?

[johnmhoran]

@TG1999 In Chrome the color of the top table's borders looks lighter than the border of the table below -- maybe Firefox displays that color differently? In any event they should have the same colored border (tho not sure if that would change the display).

[johnmhoran]

otoh looking in Firefox at the current hosted VCIO does show the top table's borders, fwiw.

[johnmhoran]

For some reason Firefox and Chrome seem to be using different CSS. These are both from my updated local main, Firefox then Chrome -- even the indentation differs.

[johnmhoran]

@TG1999 I need to update my prior comments -- in Chrome, I'd neglected to hit ctrl-F5 to refresh the CSS, and when I do, in my local instance the top table has no borders and has the same indentation/horizontal alignment as Firefox. This is the refreshed Chrome displaying the updated main locally:

Both Chrome and Firefox when refreshed still display the borders for the public VCIO.

The latest merge into main is my Package UI/API PR. I don't recall doing any Vulnerability UI-related work in that PR but am guessing some change I made removed the borders and changed the indent/alignment. Will dig into that now.

[johnmhoran]

Looks like my CSS change for the Package details table borders gave effect to a previously-overidden prior border=0 setting for that Vulnerability details table. Creating a new branch to fix.

[johnmhoran]

Fixed with #1358 and merged in December 2023. Closing.