Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate xen importer #1044

Merged
merged 5 commits into from
Jan 26, 2023
Merged

Migrate xen importer #1044

merged 5 commits into from
Jan 26, 2023

Conversation

TG1999
Copy link
Contributor

@TG1999 TG1999 commented Dec 21, 2022

Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com

pombredanne
pombredanne requested changes Dec 24, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. The tests are failing and I have a few comments for your consideration.

vulnerabilities/importers/xen.py Outdated Show resolved Hide resolved
vulnerabilities/importers/xen.py Outdated Show resolved Hide resolved
vulnerabilities/tests/test_xen.py Show resolved Hide resolved
@TG1999
Copy link
Contributor Author

TG1999 commented Dec 27, 2022

License for this importer will be GPL-2 as stated here https://wiki.xenproject.org/wiki/Xen_FAQ_General

TG1999
TG1999 commented Jan 6, 2023
View reviewed changes
Copy link
Contributor Author

@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions:

vulnerabilities/importers/xen.py Show resolved Hide resolved
TG1999
TG1999 commented Jan 6, 2023
View reviewed changes
Copy link
Contributor Author

@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions

vulnerabilities/references.py Outdated Show resolved Hide resolved
vulnerabilities/references.py Outdated Show resolved Hide resolved
vulnerabilities/references.py Outdated Show resolved Hide resolved
vulnerabilities/references.py Outdated Show resolved Hide resolved
vulnerabilities/importers/xen.py Outdated Show resolved Hide resolved
vulnerabilities/tests/test_data/xen_data.json
],
"files": [
{
"name": "xsa26-4.1.patch",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should store patches from Xen advisories.

@TG1999 TG1999 mentioned this pull request Jan 6, 2023
Open
pombredanne
pombredanne approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pombredanne
pombredanne requested changes Jan 6, 2023
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to get a proper license

@TG1999 TG1999 added this to the v32.0.0 milestone Jan 17, 2023
@johnmhoran
Copy link
Member

LGTM 👍

TG1999 and others added 5 commits January 27, 2023 01:31
@TG1999
Migrate xen importer
c37f0e4 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Address review comments
8a65a97 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Apply suggestions from code review
fd0ae94 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Adjust tests according to rebase
d0edf65 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Add license for xen importer
94c2c8c 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 TG1999 merged commit 8b59296 into aboutcode-org:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne requested changes

@johnmhoran johnmhoran johnmhoran approved these changes

Assignees

@johnmhoran johnmhoran

Labels
None yet
Projects
None yet
Milestone
v32.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@TG1999 @johnmhoran @pombredanne