Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migrations to remove corrupted advisories #1086 #1087

Merged
merged 3 commits into from
Jan 25, 2023

Conversation

TG1999
Copy link
Contributor

@TG1999 TG1999 commented Jan 20, 2023

Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com

@TG1999 TG1999 requested a review from pombredanne January 25, 2023 12:51
@TG1999 TG1999 changed the title Add migrations to remove corrupted advisories Add migrations to remove corrupted advisories #1086 Jan 25, 2023
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There is only a small nit picking for your consideration.

vulnerabilities/tests/test_data_migrations.py Outdated Show resolved Hide resolved
@pombredanne
Copy link
Member

You also need to renumber your migration to 038

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 TG1999 merged commit 0d55b24 into aboutcode-org:main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants