Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vulnerability aliases at package level in API #1104

Merged

Conversation

TG1999
Copy link
Contributor

@TG1999 TG1999 commented Jan 26, 2023

This is a first step towards #1090

Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com

@TG1999 TG1999 requested a review from pombredanne January 26, 2023 17:24
@TG1999 TG1999 added this to the v32.0.0 milestone Jan 26, 2023
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
See a change to get something simpler as list of Aliases.
I wonder if we can get a few more tests too?

@TG1999 TG1999 force-pushed the add_alias_to_package_endpoint branch from 6c6cf7c to 3585561 Compare January 27, 2023 12:16
@TG1999 TG1999 requested a review from pombredanne January 27, 2023 22:07
@TG1999 TG1999 force-pushed the add_alias_to_package_endpoint branch 2 times, most recently from 1fb650e to 700b3ba Compare January 31, 2023 12:32
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 TG1999 force-pushed the add_alias_to_package_endpoint branch from 700b3ba to 6e31d1d Compare February 2, 2023 16:01
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pombredanne pombredanne merged commit 770d22f into aboutcode-org:main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants