Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github importer #1149

Merged
merged 1 commit into from
Mar 15, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions vulnerabilities/importers/github.py
Original file line number Diff line number Diff line change
Expand Up @@ -216,12 +216,6 @@ def get_purl(pkg_type: str, github_name: str) -> Optional[PackageURL]:
logger.error(f"get_purl: Unknown package type {pkg_type}")


class InvalidVersionRange(Exception):
"""
Raises exception when the version range is invalid
"""


def process_response(resp: dict, package_type: str) -> Iterable[AdvisoryData]:
"""
Yield `AdvisoryData` by taking `resp` and `ecosystem` as input
Expand Down Expand Up @@ -268,7 +262,7 @@ def process_response(resp: dict, package_type: str) -> Iterable[AdvisoryData]:
affected_range = build_range_from_github_advisory_constraint(
package_type, affected_range
)
except InvalidVersionRange as e:
except Exception as e:
logger.error(f"Could not parse affected range {affected_range!r} {e!r}")
affected_range = None
if fixed_version:
Expand Down