-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for v32.0.0 #1169
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TG1999
force-pushed
the
add_doc_for_v32
branch
4 times, most recently
from
April 3, 2023 20:01
7af5a86
to
2aeafed
Compare
AyanSinhaMahapatra
requested changes
Apr 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TG1999 looking good, thanks! A couple of nits for your consideration here.
johnmhoran
reviewed
Apr 11, 2023
johnmhoran
reviewed
Apr 11, 2023
johnmhoran
reviewed
Apr 11, 2023
TG1999
force-pushed
the
add_doc_for_v32
branch
3 times, most recently
from
April 12, 2023 12:59
3ae491e
to
6698935
Compare
TG1999
force-pushed
the
add_doc_for_v32
branch
3 times, most recently
from
April 21, 2023 10:36
d81092c
to
bc86f95
Compare
pombredanne
requested changes
Apr 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more feedback!
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to make this documentation friendly for a totally new user who is going to use vulnerablecode for the first time. As discussed here #1148 (comment)