-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support to EPSS #1481
Add Support to EPSS #1481
Conversation
@ziadhany Perhaps you could add this link |
@pombredanne @DennisClark @keshav-space @johnmhoran @Hritik14
|
@ziadhany as discussed in our meeting, please do not include the EPSS score (0 to 1) in the Severity Score Range (0-10) since they don't really make sense together. |
EPSS scores are probabilities and could be represented in the 1-100 range by multiplying by 100. |
@Hritik14 2- normalize the whole score range to [0,1] ( CVSS values ): This approach could be useful, however, most people are more concerned with the vulnerability's CVSS rating [ 0: 10 ] 3- Keep the EPSS score separate from the severity score range |
0f7938c
to
bc44a84
Compare
Please add screenshots in UI for both cases when we have and when we do not have "published_at" |
@TG1999 Here are all the screenshots for the EPSS UI. |
@ziadhany please do same for API. Thanks and merge this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@ziadhany tests are failing, please look! |
@ziadhany error persists, CI is still failing |
@ziadhany please see this PR, tests are failing |
Fix migration conflict Fix cargo test ( add ref type ) Fix merge conflict Add api test for epss Keep the EPSS score separate from the severity score range Add epss tab Add epss to severity scoring Add published_at date to the Vulnerability score model. Add EPSS importer Add EPSS model Add EPSS UI Add EPSS to api Fix api test Signed-off-by: ziadhany <ziadhany2016@gmail.com>
issue #850 #1474