Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support to EPSS #1481

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Add Support to EPSS #1481

merged 1 commit into from
Aug 6, 2024

Conversation

ziadhany
Copy link
Collaborator

@ziadhany ziadhany commented May 19, 2024

issue #850 #1474

Screenshot from 2024-06-01 02-59-57

Screenshot from 2024-06-01 03-00-46

@DennisClark
Copy link
Member

DennisClark commented May 21, 2024

@ziadhany Perhaps you could add this link
https://www.first.org/epss/
to help people understand who the "Exploit Prediction Scoring System" is,
and then it should be good to go.

@ziadhany
Copy link
Collaborator Author

@pombredanne @DennisClark @keshav-space @johnmhoran @Hritik14
I added the EPSS to the scoring system the API looks good
but there is a problem with the UI :
1- Severity score range ( Should we ignore the EPSS ? ) I think yes
2- where should we add the published_at and percentile? ( Severities vectors, ... ? )

{
    "url": "http://127.0.0.1:8001/api/vulnerabilities/132176",
    "vulnerability_id": "VCID-1116-rhyx-aaab",
    "summary": "",
    "aliases": [
        {
            "alias": "CVE-2019-14599"
        }
    ],
    "fixed_packages": [],
    "affected_packages": [],
    "references": [
        {
            "reference_url": "https://api.first.org/data/v1/epss?cve=CVE-2019-14599",
            "reference_id": "",
            "scores": [
                {
                    "value": "0.00044",
                    "scoring_system": "epss",
                    "scoring_elements": "0.12215",
                    "published_at": "2024-05-22T00:00:00Z"
                }
            ],
            "url": "https://api.first.org/data/v1/epss?cve=CVE-2019-14599"
        }
    ],
    "weaknesses": [],
    "resource_url": "http://127.0.0.1:8001/vulnerabilities/VCID-1116-rhyx-aaab"
}

image

@DennisClark
Copy link
Member

@ziadhany as discussed in our meeting, please do not include the EPSS score (0 to 1) in the Severity Score Range (0-10) since they don't really make sense together.

@Hritik14
Copy link
Collaborator

EPSS scores are probabilities and could be represented in the 1-100 range by multiplying by 100.

@ziadhany
Copy link
Collaborator Author

EPSS scores are probabilities and could be represented in the 1-100 range by multiplying by 100.

@Hritik14
we have three options
1- multiple EPSS score by (10, 100, ...): This approach has limitations and may not be effective for all EPSS scores
CVE-1999-0005: epss score: 0.91963 -> (9.1963, 91.963, ...)
CVE-2023-5868: epss score: 0.0018 -> (0.018, 0.18 , ...)
CVE-2023-4806: epss score: 0.00097 -> (0.0097, 0.097, ...)

2- normalize the whole score range to [0,1] ( CVSS values ): This approach could be useful, however, most people are more concerned with the vulnerability's CVSS rating [ 0: 10 ]

3- Keep the EPSS score separate from the severity score range

@ziadhany ziadhany force-pushed the epss branch 2 times, most recently from 0f7938c to bc44a84 Compare June 4, 2024 00:40
@TG1999 TG1999 self-requested a review July 9, 2024 15:30
@TG1999
Copy link
Contributor

TG1999 commented Jul 16, 2024

Please add screenshots in UI for both cases when we have and when we do not have "published_at"

@ziadhany
Copy link
Collaborator Author

@TG1999 Here are all the screenshots for the EPSS UI.
Screenshot from 2024-07-17 21-07-01

Screenshot from 2024-07-17 22-21-02

Screenshot from 2024-07-17 22-43-39

Screenshot from 2024-07-17 22-40-13

@TG1999
Copy link
Contributor

TG1999 commented Jul 22, 2024

@ziadhany please do same for API. Thanks and merge this

Copy link
Contributor

@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TG1999
Copy link
Contributor

TG1999 commented Jul 22, 2024

@ziadhany tests are failing, please look!

@ziadhany
Copy link
Collaborator Author

@ziadhany tests are failing, please look!

@TG1999 I resolved the test issues. One was due to migration conflicts, and the other was related to the cargo ref type. I'm unsure why the cargo ref type issue didn't appear in the ref type pull request.

@TG1999
Copy link
Contributor

TG1999 commented Jul 22, 2024

#1502 is reverted, @ziadhany please also fix the tests there and get it merged

@TG1999
Copy link
Contributor

TG1999 commented Jul 22, 2024

@ziadhany error persists, CI is still failing

@ziadhany
Copy link
Collaborator Author

@ziadhany error persists, CI is still failing

@TG1999 Please merge the ref type pull request before this one and rerun the CI.

@TG1999
Copy link
Contributor

TG1999 commented Jul 22, 2024

@ziadhany please see #1518, please do the required/needed changes to get CI passing there

@TG1999
Copy link
Contributor

TG1999 commented Aug 6, 2024

@ziadhany please see this PR, tests are failing

Fix migration conflict
Fix cargo test ( add ref type )
Fix merge conflict
Add api test for epss
Keep the EPSS score separate from the severity score range
Add epss tab
Add epss to severity scoring
Add published_at date to the Vulnerability score model.
Add EPSS importer
Add EPSS model
Add EPSS UI
Add EPSS to api
Fix api test

Signed-off-by: ziadhany <ziadhany2016@gmail.com>
@ziadhany
Copy link
Collaborator Author

ziadhany commented Aug 6, 2024

@ziadhany please see this PR, tests are failing

@TG1999 Done

@ziadhany ziadhany merged commit 1561efe into aboutcode-org:main Aug 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Validated
Development

Successfully merging this pull request may close these issues.

5 participants