-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Npm importer to aboutcode pipeline #1574
Conversation
keshav-space
commented
Aug 28, 2024
- Reference Use the SCIO Pipeline Mechanism for Importers/Improvers #1509
@keshav-space is there anything remaining here, can we go ahead and review / merge this ? |
@TG1999 I will add a small data migration to change the value of |
@keshav-space sure, let me know when it's ready for review |
759a090
to
04442b7
Compare
@TG1999 ready for your review :) |
ping @TG1999 |
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
- For now pipeline_id should be module name of pipeline Signed-off-by: Keshav Priyadarshi <git@keshav.space>
- Update the created_by field on old advisory to new pipeline_id Signed-off-by: Keshav Priyadarshi <git@keshav.space>
04442b7
to
baa3fd5
Compare
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Log from a clean run.
|