Fix Apache Tomcat Importer by not using Semver #1791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kunalsz <kunalavengers@gmail.com>
Signed-off-by: kunalsz <kunalavengers@gmail.com>
kunalsz
changed the title
keshav-space
requested changes
Apr 16, 2025
There was a problem hiding this comment.
@kunalsz IMO this is not the right approach instead we should fix the version_class in upstream univers ApacheVersionRange.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to the issue #1555
Changes made:
Semverversioning is removed which was creating problemsMavenversioning is being usedApache Tomcat Versioning Overview
Apache Tomcat versions follow a Maven-like versioning scheme, which can include:
This is not Semver-compliant, but Maven versioning handles all of these cases
@TG1999 looking forward to your insights !