Add Gitlab datasource #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
keshav-space
force-pushed
the
gitlab_datasource
branch
4 times, most recently
from
cd1ee0b to
06265f6
Compare
keshav-space
force-pushed
the
gitlab_datasource
branch
from
06265f6 to
55fc8a8
Compare
TG1999
requested changes
Sep 5, 2022
vulntotal/datasources/gitlab.py
Outdated
| os.remove(response.location) | ||
|
|
||
|
|
||
| def clear_download(location): |
vulntotal/datasources/gitlab.py
Outdated
| return f"{ecosystem}/{package_name}" | ||
|
|
||
|
|
||
| def download_subtree(package_slug: str, speculative_execution=False): |
vulntotal/datasources/gitlab.py
Outdated
| } | ||
|
|
||
|
|
||
| def get_package_slug(purl): |
vulntotal/datasources/gitlab.py
Outdated
| shutil.rmtree(location) | ||
|
|
||
|
|
||
| def get_casesensitive_slug(path, package_slug): |
vulntotal/datasources/gitlab.py
Outdated
|
|
||
| while hasnext: | ||
| response = requests.post(url, json=payload).json() | ||
| paginated_tree = response[0]["data"]["project"]["repository"]["paginatedTree"] |
There was a problem hiding this comment.
well, that won't work here.
>>> from vulnerabilities.utils import get_item
>>> data = [
... {
... "data": {
... "project": {
... "repository": {
... "paginatedTree": {
... "pageInfo": {
... "endCursor": "e1d88bf61d8f6e2d39bdae52121d2c19e0a86ea6",
... "startCursor": "",
... "hasNextPage": True
... },
... "nodes": [
... {
... "trees": {
... "nodes": [
... {
... "flatPath": "pypi/AccessControl"
... },
... {
... "flatPath": "pypi/Acqusition"
... },
... {
... "flatPath": "pypi/Beaker"
... }
... ]
... }
... }
... ]
... }
... }
... }
... }
... }
... ]
>>> get_item(data, 0, 'data', 'project', 'repository', 'paginatedTree')
dictionary must be of type `dictThere was a problem hiding this comment.
I meant this
Suggested change
| paginated_tree = response[0]["data"]["project"]["repository"]["paginatedTree"] | |
| assert len(response) > 0 | |
| data = response[0] | |
| paginated_tree = get_item(data, "data", "project", "repository", "paginatedTree") |
You are not checking if the item you are accesing exists in the dictionary or not
vulntotal/datasources/gitlab.py
Outdated
| paginated_tree = response[0]["data"]["project"]["repository"]["paginatedTree"] | ||
|
|
||
| for slug in paginated_tree["nodes"][0]["trees"]["nodes"]: | ||
| if slug["flatPath"].lower() == package_slug.lower(): |
There was a problem hiding this comment.
There was a problem hiding this comment.
Check my comment above for same.
vulntotal/datasources/gitlab.py
Outdated
|
|
||
|
|
||
| def parse_interesting_advisories(location, version, delete_download=False) -> Iterable[VendorData]: | ||
| path = Path(location) |
vulntotal/datasources/gitlab.py
Outdated
| if package_slug.lower().startswith(slug["flatPath"].lower()): | ||
| return get_gitlab_style_slug(slug["flatPath"], package_slug) | ||
|
|
||
| payload[0]["variables"]["nextPageCursor"] = paginated_tree["pageInfo"]["endCursor"] |
There was a problem hiding this comment.
There was a problem hiding this comment.
Check my comment above for same.
|
Add doctsrings for all the functions and also add doctests/ unit tests for functions which have not been tested at all |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #836