Improve UI #894
Merged
Improve UI #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: #798 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* Rename get_package_types() to get_known_package_types() * Add doctring Reference: #798 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Reference: #798 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* remove duplicated code * use same naming conventions of robjects and templates for packages and vulnerabilities. * Use constant for PAGE_SIZE Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
- Use buitin ListView with standard pagination - More counts and empty logic displays to templates - Use includes for search boxes and common JS scripts - Remove search by type. Instead allow using a partial purl with a type - Format templates to avoid very long lines - Expand package search to work with all purl attributes including non parsing purls. Use case insensitive contains lookup otherwise. - Expand vulnerability search to use case insensitive contains lookup over vcid, aliases, reference ids and summary - Prefer "VulnerableCode" over "VCIO" Reference: #798 Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Remove trailing spaces and format for readability. Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Also handle renaming of vulnd_id to vulnerability_id Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
|
All green. We reviewed this in our weekly call yesterday https://github.com/nexB/vulnerablecode/wiki/WeeklyMeetings and this was a go. Merging now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies improvements on top of the PR #847