Skip to content

Commit

Permalink
Make sure we mark the proc as WAITPID status in signalled and non-zer…
Browse files Browse the repository at this point in the history
…o exit cases
  • Loading branch information
abouteiller committed Nov 20, 2017
1 parent e3006ca commit 199f5f0
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
3 changes: 0 additions & 3 deletions orte/mca/errmgr/default_orted/errmgr_default_orted.c
Original file line number Diff line number Diff line change
Expand Up @@ -594,9 +594,6 @@ static void proc_errors(int fd, short args, void *cbdata)
if (ORTE_FLAG_TEST(child, ORTE_PROC_FLAG_ALIVE)) {
ORTE_FLAG_UNSET(child, ORTE_PROC_FLAG_ALIVE);
}
if (!ORTE_FLAG_TEST(child, ORTE_PROC_FLAG_WAITPID)) {
ORTE_FLAG_SET(child, ORTE_PROC_FLAG_WAITPID);
}
/* if we were ordered to terminate, see if
* any of our routes or local children remain alive - if not, then
* terminate ourselves. */
Expand Down
6 changes: 6 additions & 0 deletions orte/mca/odls/base/odls_base_default_fns.c
Original file line number Diff line number Diff line change
Expand Up @@ -1416,6 +1416,9 @@ void ompi_odls_base_default_wait_local_proc(orte_proc_t *proc, void* cbdata)

/* provide a default state */
state = ORTE_PROC_STATE_WAITPID_FIRED;
/* regardless of our eventual code path, we need to
* flag that this proc has had its waitpid fired */
ORTE_FLAG_SET(proc, ORTE_PROC_FLAG_WAITPID);

/* check to see if a sync was required and if it was received */
if (ORTE_FLAG_TEST(proc, ORTE_PROC_FLAG_REG)) {
Expand Down Expand Up @@ -1521,6 +1524,9 @@ void ompi_odls_base_default_wait_local_proc(orte_proc_t *proc, void* cbdata)
"%s odls:waitpid_fired child process %s terminated with signal",
ORTE_NAME_PRINT(ORTE_PROC_MY_NAME),
ORTE_NAME_PRINT(&proc->name) ));
/* regardless of our eventual code path, we need to
* flag that this proc has had its waitpid fired */
ORTE_FLAG_SET(proc, ORTE_PROC_FLAG_WAITPID);
/* Do not decrement the number of local procs here. That is handled in the errmgr */
}

Expand Down

0 comments on commit 199f5f0

Please sign in to comment.