-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vulnerabilities in dependencies #20547
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Muximize
force-pushed
the
fix-vulnerabilities
branch
from
August 17, 2024 07:55
d87305b
to
8d17dfb
Compare
Muximize
force-pushed
the
fix-vulnerabilities
branch
from
September 2, 2024 08:40
8d17dfb
to
c361d2f
Compare
I rebased this on latest dev to fix a merge conflict. |
Great initiative, I was just going to open an issue because of transitive package vulnerabilities that I'd like to see fixed 👍 |
@maliming I see now ABP is usually quite conservative in updating dependencies, so maybe you can skip the last commit, or cherry pick what you like in this PR. |
Muximize
force-pushed
the
fix-vulnerabilities
branch
2 times, most recently
from
September 11, 2024 08:34
687c2b4
to
b24467b
Compare
Muximize
force-pushed
the
fix-vulnerabilities
branch
from
September 12, 2024 08:51
b24467b
to
1bcbf38
Compare
Muximize
force-pushed
the
fix-vulnerabilities
branch
from
September 12, 2024 08:59
1bcbf38
to
2042485
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves 417 instances of 14 vulnerabilities in multiple versions of these 10 (transitive) dependencies:
These stats are only for the framework solution but the modules where also fixed. These where found using:
Notes
Because it gets annoying to keep having to fix these in our project, I thought maybe I should fix it at the source 😇
Instead of just updating the vulnerable package versions, I did some cleanup to reduce the amount of transitive dependencies and to make the process of updating them easier in the future:
netstandard2.0
andnetstandard2.1
targets of some dependencies. Because ABP 8 requiresnet8.0
anyway, I assume those targets can be safely dropped as an easy fix.AssetTargetFallback
can then be dropped from projects too.