Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy expandable feature for documentation #21689

Merged
merged 4 commits into from
Dec 25, 2024
Merged

Lazy expandable feature for documentation #21689

merged 4 commits into from
Dec 25, 2024

Conversation

realLiangshiwei
Copy link
Member

Description

Resolves #21095

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (or no need to document or I will create a separate documentation issue)

How to test it?

Run the VoloDocs.Web app

@realLiangshiwei realLiangshiwei added this to the 9.1-preview milestone Dec 20, 2024
salihozkara
salihozkara requested changes Dec 23, 2024
View reviewed changes
Copy link
Member

@salihozkara salihozkara left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create the url with Url.Page instead of creating it from js? We may have changed the routing in Asp Net Core.
https://github.com/abpframework/abp/blob/dev/modules/docs/src/Volo.Docs.Web/Utils/IDocsLinkGenerator.cs

@realLiangshiwei
Copy link
Member Author

@salihozkara okay , I added a new DocumentNavigationController to generate links.

oykuermann
oykuermann requested changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@oykuermann oykuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items should be rendered if the main page is open.
image
image

@oykuermann
Copy link
Contributor

Items should be rendered if the main page is open. image image

This problem still not resolved:
image

oykuermann
oykuermann requested changes Dec 25, 2024
View reviewed changes
Copy link
Contributor

@oykuermann oykuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check after changes.

@oykuermann oykuermann merged commit dc3a6d5 into dev Dec 25, 2024
3 checks passed
@oykuermann oykuermann deleted the Lazy-expandable branch December 25, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salihozkara salihozkara salihozkara approved these changes

@oykuermann oykuermann oykuermann approved these changes

Assignees
No one assigned
Labels
abp-module-docs feature
Projects
None yet
Milestone
9.1-preview
Development

Successfully merging this pull request may close these issues.

Lazy expandable feature for documentation
3 participants
@realLiangshiwei @oykuermann @salihozkara