Skip to content

heap sorting added #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

heap sorting added #7

wants to merge 3 commits into from

Conversation

sohailg
Copy link

@sohailg sohailg commented Oct 9, 2018

No description provided.

@abranhe
Copy link
Owner

abranhe commented Oct 10, 2018

Hi, @sohailg thanks for contributing to The All ▲lgorithms project, the huge collection of algorithms implemented in different languages.

Before merging the pull request you will need to review the contributing guide because there are changes must be done.

├── allalgorithms
│   │── sorting
|   |    │── bubble_sort.py
|   |    └── merge_sort.py
│   └── searches
|        │── binary_search.py
|        └── linear_search.py
├── docs
│   │── sorting
|   |    │── bubble-sort.md
|   |    └── merge-sort.md
│   └── searches
|        │── binary-search.md
|        └── linear-search.md
└── tests
    │── test_searches.py
    └── test_sorting.py

The above style is required so you may need to add the algorithm along the tests and documentation

Also, the algorithm is implemented in a folder called python-lib-master which make any sense, and the function name heapSort(arr) doesn't follow the cammel_case style. Make sure to fix!!

@abranhe abranhe added invalid This doesn't seem right Tests needed Test are required, so should be added Documentation needed Documentation is required, so should be added Doesn't follow style Does not follow the correct style labels Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation needed Documentation is required, so should be added Doesn't follow style Does not follow the correct style invalid This doesn't seem right Tests needed Test are required, so should be added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants