-
-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Not all files being downloaded #2562
Comments
There could be any number of reasons why the data is empty. Question: Are the empty / non-download items all in shared folders that you have added to your account online via "Add to my OneDrive"? If yes, then this could be path related as to how the client is looking for the files. Now .. v2.4.x client code, if it has a bug, it will not be fixed. What I urge you to do is try the very mature 'alpha-3' code (yes there are logging output problems, 'alpha-4' is about a week away) - please re-test your problem with 'alpha-3' Please read: |
Ok, tried to so but using the alpha-3 build yields the error
In 2.4 I did not need to set this value and |
You need to remove it from your config file for personal accounts |
@robertschulze |
From the above, and your logfile, your output for your application configuration is not correct - as you indicate here that you are not using a synclist file, but your console log output shows that you are using a sync_list file. For example::
So is your issue that items are not being downloaded due to a mis-configured 'sync_list' file? Regarding this item: This 'config' problem stems from using 'OneDriveGUI' that incorrectly writes out empty configuration items. If you are using this, and using 'alpha-3' - you need to update your GUI to this: https://github.com/bpozdena/OneDriveGUI/releases/tag/v1.1.0alpha0 Please can you:
|
Indeed, this solved the issue. I will try to follow up on the logs tonight. |
Hi, Unfortunately the alpha crashes, here the end of the log file (it contains all kinds of access tokens, so not sure whether it's safe to upload it here):
Also tried --synchronize as well as --monitor, also with --resync added, but fails in all cases. |
* Potentially fix crash identified by #2562
Many thanks for this output that identifies a previously unknown issue - greatly appreciated. I have updated the 'alpha-3' code with a potential fix for this crash: If you rebuild your 'alpha-3' code (you may need to delete the local git pull directory as well) and rebuild, you should get client version If you can test this version please that would be greatly appreciated as this should fix this initial issue you are having with 'alpha-3', but the positive here is that the client has found 201+ items to process from this Shared Folder ( |
@robertschulze |
Hi,
in the end, nothing is copied and the log ends:
My command was |
@robertschulze The items are being added to be processed, something is happening - but its not in your output there. Please can you archive and email the entire debug log to the support email address. |
@robertschulze |
After analysis of the debug log, this appears to be an API bug. The JSON response from the OneDrive API includes erroneus HTML characters in JSON elements ( Raised an API Bug as the API specification does not articulate that it will send HTML characters embedded in JSON elements. API Bug Reference: OneDrive/onedrive-api-docs#1765 There are 2 ways to solve the actual issue:
|
Hi,
into the For one, I still see %20 in the file paths below the main dir (now with the new WARNING you implemented):
but also none of the files are ultimately copied because of
I have sent the full log via mail. |
Thanks for the updated log file, will look at this later.
Correct - because either the file online or this is a OneDrive API bug - you are getting
|
@robertschulze Please hold off on updating / doing any more testing until I have a chance to run some testing here. |
@robertschulze
With the first scenario, I was able to replicate the Please can you rebuild your client, using 'alpha-4' code - refer to https://github.com/abraunegg/onedrive/discussions/2565 for details. When you are running 'alpha-4' - your client version should be |
@abraunegg: Thanks for the new version: with original folder name "OneDrive-Constanze" (in source OneDrive) and link (in actual OneDrive that is to be synched) "OneDrive - Constanze" sync is now working, BUT: into subfolder "OneDrive-Constanze" instead of "OneDrive - Constanze"
|
You will need to 'clean' up your local and remote OneDrive. Suggested path of resolution:
I have now resolved this issue, re-validated and tested with OneDrive Personal & OneDrive Business Shared Folders. Please can you rebuild your client so that you get: Example output:
'DESIGN _ BRASIL' is a Shared Folder from the root of the account that is sharing the data with the test account.
|
@abraunegg Hi, I tried with the new version but the result is still the same, the files are synced into "OneDrive-Constanze" instead of "OneDrive - Constanze". Should I send you the log file again? |
Please send the entire debug log when possible. The issue is probably to do with the difference between the actual shared folder name (remote name) and the link under your account. I am also away from tools until the new year. |
I have responded via email - if you could review and get back to me that would be greatly appreciated. |
@robertschulze |
@abraunegg |
Looking at your logfile - your remote folder name is 'OneDrive-Constanze' which is why the data is being synced to this folder: If you search your logfile for: This is why your data is syncing to 'OneDrive-Constanze' and not 'OneDrive - Constanze' Please look at how your folder are all named - as you will need to do a cleanup of everything first (online and your local filesystem), then re-create how you want it to be online (using 'OneDrive - Constanze') because of the bug|issue identified where your original rename of 'OneDrive - Constanze' was done because it contained HTML Characters. Additionally, it would be wise to also uplift your client version to 'alpha-5' - please read #2585 for details. |
I have to admin I am a bit confused. Let me recap the status:
What I understood is that the item to be synced is still named without spaces (as it needs be due to the bug) but since the link has been renamed and the change in name is reflected both in the Web GUI as well as the Desktop client, shouldn't also the Linux client use the name of the link instead of the original folder name? |
@robertschulze Then, share that folder with the account you are syncing the data with. Renaming the folder to remove the HTML Ascii cide issue should have been just a one time item - if i rename things online using a 'space' - then it uses a space ... so no idea how or why you ended up with %20 to begin with. Please clean up everything, remove the shared with me items, rename things as per how you are expecting it, reshare and then retest. If you look at the non debug log (just one -v) you should see that the shared folder is pulled in and used, and any local data in that local folder will go to the correct online shared folder. |
@abraunegg Thanks, indeed, now with the name containing (correct) spaces in Account 1 (and thus appears with correct name in Account 2, no rename necessary) the sync is working fine. Thanks! |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Describe the bug
I am facing the same issue as @nijatismayilzada however, very strangely - only for one of my shared folders (I have four of them in my OneDrive). So while two appear to sync fine, one (which in Windows and on the Web is full of files) is containing only empty directories and whatever I tried in terms of (re)configuration, I was not able to make it sync. What could I be missing?
References to similar issues possibly related:
#1665
#563
#2550
Operating System Details
Linux atom 5.15.0-91-generic #101-Ubuntu SMP Tue Nov 14 13:30:08 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 22.04.3 LTS Release: 22.04 Codename: jammy
Client Installation Method
From Source
OneDrive Account Type
Personal
What is your OneDrive Application Version
onedrive v2.4.25-1+np1
What is your OneDrive Application Configuration
What is your 'curl' version
Where is your 'sync_dir' located
Local
What are all your system 'mount points'
//hyperv/3 on /media/3 type cifs (rw,relatime,vers=2.1,cache=strict,username=Administrator,uid=1000,noforceuid,gid=100,noforcegid,addr=192.168.3.11,file_mode=0777,dir_mode=0777,soft,nounix,serverino,mapposix,rsize=1048576,wsize=1048576,bsize=1048576,echo_interval=60,actimeo=1,closetimeo=1)
What are all your local file system partition types
How do you use 'onedrive'
both from the OneDriveGUI as well as directly via the console (tried both --monitor and --synchronize)
Steps to reproduce the behaviour
run onedrive either from the command line with either command line option
CONSOLE.robert.onedrive.log
Complete Verbose Log Output
Screenshots
No response
Other Log Information or Details
Additional context
No response
The text was updated successfully, but these errors were encountered: