Update version release notification handling #2267
Conversation
abraunegg
commented
Dec 15, 2022
abraunegg
commented
- Update the GitHub version check to also utilise the date a release was done, to allow 1 month grace period before generating obsolete version message.
* Update the GitHub version check to also utilise the date a release was done, to allow 1 month grace period before generating obsolete version message.
src/util.d
Outdated
| if (releaseGracePeriod.toUnixTime() > currentTime.toUnixTime()) { | ||
| writeln(); | ||
| log.logAndNotify("INFO: A new onedrive client version is available. Please upgrade your client version when possible."); | ||
| log.vlog("Current Application Version: ", applicationVersion); |
There was a problem hiding this comment.
When testing, I saw only the "A new onedrive client..." message (without any version numbers) and I came here to ask if you might consider adding the version numbers to that message. But, it looks like you already have them, though they're only displayed when the user asks for verbose output?
I wonder if they are worth "upgrading" to display whenever the warning is - it seems like if the user is to take action on the upgrade message, it would almost always be useful for them to know their current version and the latest version to be able to check their upstream package repository (or pester the maintainer!).
There was a problem hiding this comment.
@aclindsa
I was more thinking to just advise the version when obsolete - however PR is updated and will merge into 'master'
* Update PR
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
