-
-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework #2608 with #2661 for testing on physical systems #2686
Rework #2608 with #2661 for testing on physical systems #2686
Conversation
abraunegg
commented
Mar 30, 2024
- Rework Refactor OneDriveApi implementation #2608 with OneDrive Client Version v2.5.0-rc1 #2661 for testing on physical systems
- Specifically testing these issues from RC1:
- Re-connect to WiFi and the client will crash with the below error messages for each thread
- Multiple functions handle errors incorrectly that do not return after retrying the function. As a result, the validation check fails when returning from the recovering retry in the original failed case, even though the operation is actually successful. (Bug: Incorrect error handling #2601)
- General usability against all other 100+ test use cases
* Initial add of PR2608
* Align to original PR2608 work
* Update with working state
Test Case 1: Disable WiFi whilst 'Processing API Response Bundle: ...' message occurs
Expected Outcome:
Result:
Post ef4e990 |
Test Case 2: Flood API with requests to trigger a 429 event
Expected Outcome:
Result:
Need to compare this with RC1 and how this is handled |
* Correct output that should be just debug only
Test Case 3: Disable WiFi whilst 'Downloading file: ' is occurring
Expected Outcome
Result:
|
Test Case 4: Use ^C to cancel application operations whilst 'Waiting for any existing threads to complete'
Expected Outcome:
Result:
Fixed
|
* Change 'defaultDataTimeout' from 240 to 60 seconds
Test Case 5: Deliberately edit 'refresh_token' to make it malformed
Expected Outcome:
Result:
Application crash due to malformed 'refresh_token' fixed via 9fa7494 |
Test Case 6: Run for extended period, deleting | creating new local data randomly in --monitor mode
Expected Outcome:
Result:
FixedFixed via: |
Test Case 7: Run for extended period, deleting | creating new local data randomly in --monitor mode
Expected Outcome:
Result:
|
General Flags: Flags that are always needed, such as warnings (-w) and directory inclusion (-J.), are added outside of the conditionals. Debug Flags: For DMD: When debugging is enabled (DEBUG=yes), the -debug flag for including debug code and -gs for generating standalone debug symbols are added. For LDC or other compilers: -d-debug for debugging and -gc for generating debugging information are added similarly when debugging is enabled. Optimization Flag: The -O flag is only added when debugging is not enabled. This ensures that the program is compiled with optimizations only when it is not in debug mode.
* Merge latest RC1 into this PR
* Refine code changes from #2608 based on memory allocation and usage
* Update code to align to v2.4.25 exception.httpStatusCode handling
* Correct ^C handling * Correct ^C exit value
Add specific example around using 'sync_list' and only including a child of a parent in the 'sync_dir'
* fix up spacing
* Make sure we return any used memory back to the OS on exit
* Remove thread_joinAll()
* Remove temp logging output
* OneDrive API Instance Cleanup - Shutdown API, free curl object and memory
* OneDrive API Instance Cleanup - Shutdown API, free curl object and memory
If possible - please can you test this PR in your environment in the next few days ? This PR will become the basis for v2.5.0-rc2 Specifically, looking for you to test and evaluate:
Notes
|
* Update so that the available processPool worker threads equals the number of threads set in the application configuration
* Update ^C Handling during upload|download operations
* Release files for 2.5.0-rc2 * Code changes from 2.5.0-rc1 --> 2.5.0-rc2 (#2686) * Update docs regarding Ubuntu 24.04
Closed due to #2709 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |