Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Drive listing does not loop on nextLink #2772

Conversation

megamisan
Copy link
Contributor

@megamisan megamisan commented Aug 13, 2024

Closes #2771

Before: rc3-output.txt
After: fix-output.txt

Sensitive data removed from outputs.

Successfully compiled on minimum ldc:

(ldc-1.20.1)vscode@0dd308454835:/workspaces/onedrive$ ./configure --enable-debug --enable-notifications; make clean; make;
checking for a BSD-compatible install... /usr/bin/install -c
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for dmd... ldc2
checking version of D compiler... 1.20.1
checking for curl... yes
checking for sqlite... yes
checking for notify... no
configure: creating ./config.status
config.status: creating Makefile
config.status: creating contrib/pacman/PKGBUILD
config.status: creating contrib/spec/onedrive.spec
config.status: creating onedrive.1
config.status: creating contrib/systemd/onedrive.service
config.status: creating contrib/systemd/onedrive@.service
rm -f onedrive onedrive.o version
rm -rf autom4te.cache
rm -f config.log config.status
if [ -f .git/HEAD ] ; then \
        git describe --tags > version ; \
else \
        echo v2.5.0-rc3 > version ; \
fi
ldc2 -w -J. -g -d-debug -gc -L-lcurl -L-lsqlite3  -L-ldl src/main.d src/config.d src/log.d src/util.d src/qxor.d src/curlEngine.d src/onedrive.d src/webhook.d src/sync.d src/itemdb.d src/sqlite.d src/clientSideFiltering.d src/monitor.d src/arsd/cgi.d -ofonedrive
(ldc-1.20.1)vscode@0dd308454835:/workspaces/onedrive$ deactivate
vscode@0dd308454835:/workspaces/onedrive$ ./onedrive --version
onedrive v2.5.0-rc3-7-gbd92098

@abraunegg
Copy link
Owner

@megamisan
Many thanks for the PR and resolving this issue yourself - greatly appreciated.

@abraunegg abraunegg added this to the v2.5.0 milestone Aug 13, 2024
@abraunegg abraunegg merged commit 5e65438 into abraunegg:onedrive-v2.5.0-release-candidate-3 Aug 13, 2024
@megamisan megamisan deleted the rc3-fix-drive-enum-loop branch August 16, 2024 10:09
@abraunegg
Copy link
Owner

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Repository owner locked and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants