Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow no-sync operations to complete online account checks #2943

Merged
merged 9 commits into from
Nov 15, 2024

Conversation

abraunegg
Copy link
Owner

* Potential fix for #2941

This comment has been minimized.

@laf0rge
Copy link

laf0rge commented Nov 2, 2024

I've tested this branch, and I'm still getting:

No user or system config file found, using application defaults
Using 'user' configuration path for application config and state data: /crypt/space/home/laforge/.config/onedrive
WARNING: D-Bus message bus daemon is not available; GUI notifications are disabled
Using IPv4 and IPv6 (if configured) for all network operations
Attempting to contact Microsoft OneDrive Login Service
Successfully reached Microsoft OneDrive Login Service
Checking Application Version ...
Attempting to initialise the OneDrive API ...
Configuring Global Azure AD Endpoints
The OneDrive API was initialised successfully
Opening the item database ...
Unable to query OneDrive API to obtain required account details

If I look at the -v -v output, it looks as follows:

DEBUG: Handling a OneDrive API exception:
DEBUG: Curl debugging: 
< get https://graph.microsoft.com/v1.0/me/drive
< 400 Bad Request (2.0)
> strict-transport-security: max-age=31536000
> x-ms-ags-diagnostic: {"ServerInfo":{"DataCenter":"Japan East","Slice":"E","Ring":"5","ScaleUnit":"001","RoleInstance":"TYO1EPF00005859"}}
> date: Sat, 02 Nov 2024 06:53:34 GMT
> client-request-id: 204af09b-31ea-4200-a241-fbe01b2bebf6
> request-id: 204af09b-31ea-4200-a241-fbe01b2bebf6
> content-type: application/json
Curl response: 

----
{"error":{"code":"BadRequest","message":"Tenant does not have a SPO license.","innerError":{"date":"2024-11-02T06:53:35","request-id":"204af09b-31ea-4200-a241-fbe01b2bebf6","client-request-id":"204af09b-31ea-4200-a241-fbe01b2bebf6"}}}
----

DEBUG: onedrive.OneDriveApi.getDefaultDriveDetails() - Generated a OneDriveException
DEBUG: defaultOneDriveDriveDetails = getDefaultDriveApiInstance.getDefaultDriveDetails() generated a OneDriveException
DEBUG: Unable to query OneDrive API to obtain required account details

I of course have no idea what a 'SPO' is. The tenant is likely the share point business instance that I'm using. However, I can successfully access that instance via the browser using the same credentials. I can list and download all the folders/files of my projects there.

To clarify: The user account I'm using is an account part of a company. That company does not have any MS licenses at all; neither that corporate account nor the individual user account are meant for doing anything else but accessing a given sharepoint site which is operated by a standards body (entity developing standards for a particular industry). The company is a member of that standards organization. As stated above, accessing the sharepoint folders/files works just fine from a browser in the above-mentioned construct.

* Update PR

This comment has been minimized.

* Update PR
@abraunegg
Copy link
Owner Author

@laf0rge
Please can you re-try the PR only.

When running this PR, you should be using onedrive v2.5.2-33-g42a7bdb or greater.

This comment has been minimized.

@abraunegg abraunegg modified the milestones: v2.5.3, v2.5.x Nov 7, 2024
@abraunegg abraunegg changed the title Potential fix for #2941 Allow no-sync operations to complete online account checks Nov 15, 2024
@abraunegg abraunegg merged commit 273bcbf into master Nov 15, 2024
10 checks passed
@abraunegg abraunegg deleted the fix-issue-2941 branch November 15, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Unable to query OneDrive API to obtain required account details
2 participants