Fix Bug #3115: Add further driveId length checks when generating a /delta response for a Shared Folder

[abraunegg]

• Add further personal account driveId length checks when generating a /delta response for a Shared Folder

[murraybo]

I do have the issue you try to solve here, too.

The current version of the pull request does not fix it. It still brakes during sync.

One thing that i identified, was that the item id, which contains the drive id, need to be adjusted, too. I hacked this by adding a function:

string testProvidedItemIdForLengthIssue(string objectParentDriveId) {
     auto o = objectParentDriveId.split("!");
     
     string newEntry;
     
     newEntry = to!string(o[0].padLeft('0', 16));
     newEntry = newEntry ~ "!" ~ o[1];

     return newEntry;
 }

and calling it at sync.d:9186

This allowed me to continue in syncing the shared drive. Nevertheless it broke later due to missing entries in itemdb.

DEBUG: ONEDRIVE PERSONAL API BUG: The provided online ['parentReference']['driveId'] value is not 16 Characters in length - padding with leading zero's
DEBUG:  - old 'driveId' value = 65fb7c645f8339c
DEBUG:  - new 'driveId' value = 065fb7c645f8339c
DEBUG: Attempting to calculate initial local filesystem path for 065fb7c645f8339c and 065FB7C645F8339C!448
DEBUG: The following generated a broken database tree query:
DEBUG: Drive ID: 065fb7c645f8339c
DEBUG: Item ID: 065FB7C645F8339C!448
DEBUG: ERROR: A database consistency issue has been caught. A --resync is needed to rebuild the database.

At that point the relevant db entries looked like this

sqlite> select * from item where driveId = '65fb7c645f8339c';
65fb7c645f8339c|65FB7C645F8339C!448|...||root|...|...|2021-01-24T11:28:53.296Z|||||||||Y|
65fb7c645f8339c|065FB7C645F8339C!448|...||dir|...|...|2021-01-24T11:28:53.296Z|||||||||Y|
sqlite> 

@abraunegg This is, as far as i got on this afternoon, I hope this helps you to fix the issue.

BTW: Thanks for this create tool and the work you put into it.

[abraunegg]

@murraybo
Unfortunately The 'item id' being 15 characters, whilst technically is not correct (it should also be 16 characters) is not the root cause of the issue.

As you can reproduce this issue, please can you urgently send me via email a complete, un-redacted verbose debug log using this PR in its current state.

Please read https://github.com/abraunegg/onedrive/wiki/Generate-https-debug-log-for-support#standalone-mode to generate this log