Skip to content

Conversation

@abravalheri
Copy link
Owner

@abravalheri abravalheri commented Apr 12, 2022

Summary of changes

  • Avoid using the editables dependency
    • The current implementation is using it to simply place .pth file pointing to the project directory anyway...
    • Adding a dependency for creating a file with a single line is a bit overkill.
  • Avoid importing pkg_resources directly
    • Setuptools wants to move away from pkg_resources
  • Replace custom wheel build with re-use of bdist_wheel
    • pro: avoid re-implementing the archiving logic and make sure it is compatible with the same archive format used by the final wheels.
    • con: the API of wheel is not exactly stable or exported as public.

Closes

Pull Request Checklist

@abravalheri abravalheri force-pushed the editable-reuse-bdist-wheel branch from 842ea7b to 8ce3dca Compare April 13, 2022 09:41
@abravalheri abravalheri changed the base branch from build-editable-aggregate to editable-rework-dist-info April 13, 2022 09:41
@abravalheri abravalheri force-pushed the editable-reuse-bdist-wheel branch from 8ce3dca to a8133c0 Compare April 22, 2022 17:08
@abravalheri abravalheri force-pushed the editable-rework-dist-info branch from 4af1215 to 84171a8 Compare May 19, 2022 10:08
@abravalheri abravalheri force-pushed the editable-reuse-bdist-wheel branch from a8133c0 to 3ccb3f1 Compare May 19, 2022 10:09
@abravalheri abravalheri force-pushed the editable-reuse-bdist-wheel branch from 3ccb3f1 to c9a9fca Compare June 15, 2022 15:11
Base automatically changed from editable-rework-dist-info to build-editable-aggregate June 15, 2022 15:14
@abravalheri abravalheri merged commit 3534b07 into build-editable-aggregate Jun 15, 2022
@abravalheri abravalheri deleted the editable-reuse-bdist-wheel branch June 15, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants