feat: add --store to load a schema store #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
|
👏 Please feel free to merge when you are satisfied with the implementation! I think it is very good. Thank you very much! |
abravalheri
approved these changes
Dec 5, 2023
Co-authored-by: Anderson Bravalheri <andersonbravalheri+github@gmail.com>
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
--storeoption to load a schema store. I also considered--tools, and also considered requiring the fragment (#/properties/tools/properties), not sure which is best. I could see--storebeing expected to store something.I'm also separately looking into a way to expose the "fragment" setting to classic plugins, since I think it would be useful to have a pinnable copy of the SchemaStore.