Align tool.setuptools.dynamic.optional-dependencies with project.optional-dependencies
#170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
approved these changes
May 7, 2024
tiran
added a commit
to tiran/instructlab
that referenced
this pull request
Jul 3, 2024
setuptools < 70.0 have a bug in the schema definition for dynamic
optional dependencies. The issue was fixed in validate-pyproject 0.17
and setuptools 70.0.0.
70.1.0 has another fix that might be relevant for Python 3.10.
This fixes the following error message:
```
ValueError: invalid pyproject.toml config: `tool.setuptools.dynamic.optional-dependencies`.
configuration error: `tool.setuptools.dynamic.optional-dependencies` keys must be named by:
{format: 'python-identifier'}
```
See: abravalheri/validate-pyproject#170
Signed-off-by: Christian Heimes <cheimes@redhat.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By analysing pypa/setuptools#4341 we can see that currently
tool.setuptools.dynamic.optional-dependenciesdiffers fromproject.optional-dependencies.They probably should be the same.
PEP 685 also mentions that
So that makes sense for me.