-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support PEP 735 #208
Conversation
405e4ee
to
2b38147
Compare
2b38147
to
6fbb97e
Compare
|
6fbb97e
to
0a2ed51
Compare
0a2ed51
to
288300e
Compare
I'm fairly sure this is right. There's no generic mechanism in JSON Schema for referring to the literal keys of an input object as far as I know. |
Added a dynamic check for this case. Circular deps could probably be done too but I'm tempted to wait till we are 3.9+, since IIRC this is easy with graphlib. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @henryiii for working on this.
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Co-authored-by: Anderson Bravalheri <andersonbravalheri+github@gmail.com>
Co-authored-by: Anderson Bravalheri <andersonbravalheri+github@gmail.com>
Co-authored-by: Anderson Bravalheri <andersonbravalheri+github@gmail.com>
d0b2808
to
8ba8e1b
Compare
Add support for validating PEP 735.
Pretty sure we can't validate that include-groups point to an existing group without custom code. Though maybe there is custom code for
dynamic
already? It doesn't seem to be part of the schema like in SchemaStore's version.