Remove license and license-files from dynamic in setuptools plugin.
#27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we clarified that PEP 621 does not specify anything about the (non-standard) core metadata field `License-file` and that it is not necessary to add `license` to `dynamic` to be able to automatically fill it, there is no motivation for keeping this field in `tool.setuptools.dynamic` instead of `tool.setuptools` (directly). As such there is also little motivation to allow `license` in `dynamic`... There is nothing else setuptools can do outside of what the standard already allows. Note that this is unlikely to change with PEP 639 (the draft currently establishes that the backend can backfill `license-files` without needing an explicit `dynamic` if it is not provided).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Place license-file in tool.setuptools instead of dynamic
Now that we clarified that PEP 621 does not specify anything about the (non-standard) core metadata field
License-fileand that it is not necessary to addlicensetodynamicto be able to automatically fill it, there is no motivation for keeping this field intool.setuptools.dynamicinstead oftool.setuptools(directly).See:
As such there is also little motivation to allow
licenseandlicense-filesindynamic...There is nothing else setuptools can do outside of what the standard already allows.
Even with PEP 639 (the draft currently establishes that the backend can backfill
license-fileswithout needing an explicitdynamicif it is not provided).