Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update whisper.cpp #65

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Update whisper.cpp #65

merged 1 commit into from
Oct 17, 2024

Conversation

vietanhdev
Copy link
Contributor

Hi! Thank you for your great package.
There has been an upgraded version (v.1.7.0) of Whisper.cpp yesterday.
This PR upgrades whisper.cpp library to the latest version.

This also fixes the issue when running in the same program with llama-cpp-python 0.3.1 due to binary incompatible.
Error log:

...lib/python3.10/site-packages/llama_cpp/_ctypes_extensions.py", line 69, in load_shared_library
    raise RuntimeError(f"Failed to load shared library '{lib_path}': {e}")
RuntimeError: Failed to load shared library '...lib/python3.10/site-packages/llama_cpp/lib/libllama.so': .../lib/python3.10/site-packages/llama_cpp/lib/libllama.so: undefined symbol: ggml_exp

@absadiki
Copy link
Owner

absadiki commented Oct 7, 2024

Hi @vietanhdev,
Thank you for the contribution! I will first push a new version to PYPI first before upgrading whispcer.cpp.
I will merge this once the previous version is stable, in the meantime, can you try to run the test suite in the test folder against this new whisper.cpp version and check if everything is OK?

Also I didn't understand what issue are you referring to ? This package has nothing to do with llama-cpp-python and the dll libraries are shipped with the wheel, so basically there should be no issue with any other package!

@UsernamesLame
Copy link
Contributor

UsernamesLame commented Oct 7, 2024

LGTM. Resolves #66.

@absadiki absadiki merged commit 85a13b6 into absadiki:main Oct 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants