Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate pkg-config metadata on windows, resp. abseil_dll #1276

Closed
h-vetinari opened this issue Sep 8, 2022 · 2 comments · Fixed by conda-forge/abseil-cpp-feedstock#51 or #1341
Closed

Comments

@h-vetinari
Copy link
Contributor

I'd like to have correct pkg-config metadata also on windows. 🙃

Based on looking at AbseilHelpers.cmake, there's only one place where pkg-config metadata is being generated, and it doesn't seem to cover windows, and almost certainly doesn't cover abseil_dll (c.f. also AbseilDll.cmake).

Would be nice to have this. :)

@h-vetinari
Copy link
Contributor Author

h-vetinari commented Sep 8, 2022

Also, considering that abseil_dll is a bit of an outlier compared to the shared builds on unix (and understandably not a lot of projects take care of this distinction), it might be worth considering to generate dummy absl_<xyz>.pc files even for the DLL build, that simply do Requires: abseil_dll.

@h-vetinari
Copy link
Contributor Author

Wow, I was not aware that issues can get closed across organisations... 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant