-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable pkg-config tests on windows #242
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Seems this will need some more work on abseil upstream: abseil/abseil-cpp#1276 |
@traversaro |
The Protobuf CMake package is searched for in https://github.com/grpc/grpc/blob/v1.46.4/cmake/protobuf.cmake#L58 :
if TL;DR: pass |
Thanks a lot, I'll try this shortly! |
No success, unfortunately... 😑 |
Now that conda-forge/openssl-feedstock#106 is in, re-enable pkg-config tests.
I tried adding CMake metadata in conda-forge/libprotobuf-feedstock#128 (to re-enable the CMake tests on unix), but this caused some fall-out. However, CMake has its own custom
FindProtobuf
function that takes precedence over the packaged CMake metadata; perhaps it's still possible to nudge it to find ourprotobuf-config
-less protobuf)