Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min viable Clang-libunwind support. #1774

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

helly25
Copy link

@helly25 helly25 commented Oct 21, 2024

Min viable Clang-libunwind support.

This is from an early version of GLog and the generic implementation.

It works and is intended fro using Abseil in Bazel with Clang via https://github.com/bazel-contrib/toolchains_llvm

This is from an early version of GLog and the generic implementation.
@derekmauro
Copy link
Member

We are not going to take this contribution, at least as-is. We have our own up-to-date copy of this file that we do not export because we do not intend to support it. In addition, the use by default when using Clang isn't going to work for us.

Can I ask what is the motivation for wanting this? That would help me figure out what to do.

@helly25
Copy link
Author

helly25 commented Oct 22, 2024

We are not going to take this contribution, at least as-is. We have our own up-to-date copy of this file that we do not export because we do not intend to support it. In addition, the use by default when using Clang isn't going to work for us.
(I know what you have - check epitaphs)

Can I ask what is the motivation for wanting this? That would help me figure out what to do.

Here goes:

  • When you compile Abseil with Bazel and use --experimental_omitfp then that header will be used. So it fails as the header is not present.
  • The default Abseil unwind config does not work for me (due exclusively using Clang).
  • The patch in its current form is geared towards that and is based on the fact that when you get Clang through toolchains_llvm, then the you will also have libunwind in external/llvm_toolchain_llvm. The detection also works if you have say Ubuntu with the corresponding Clang unwind header package (e.g. libunwind-17-dev).

I was also contemplating a purely unwind based solution but was happy to just drop the remaining parts of GLog in my codebase which was used for stacktrace generation prior to this patch. So it works fine as is - for me at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants