Merge pull request #1174 from Vic-ai/master

Add end_time_mono to telemetry :stop events
absinthe-graphql · Jun 7, 2022 · 2768d10 · 2768d10
2 parents 453fd12 + ffb03e7
commit 2768d10
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/lib/absinthe/middleware/batch.ex b/lib/absinthe/middleware/batch.ex
@@ -149,8 +149,9 @@ defmodule Absinthe.Middleware.Batch do
       timeout = Keyword.get(batch_opts, :timeout, 5_000)
       result = Task.await(task, timeout)
 
-      duration = System.monotonic_time() - start_time_mono
-      emit_stop_event(duration, metadata, result)
+      end_time_mono = System.monotonic_time()
+      duration = end_time_mono - start_time_mono
+      emit_stop_event(duration, end_time_mono, metadata, result)
 
       result
     end)
@@ -178,10 +179,10 @@ defmodule Absinthe.Middleware.Batch do
     metadata
   end
 
-  defp emit_stop_event(duration, metadata, result) do
+  defp emit_stop_event(duration, end_time_mono, metadata, result) do
     :telemetry.execute(
       @batch_stop,
-      %{duration: duration},
+      %{duration: duration, end_time_mono: end_time_mono},
       Map.put(metadata, :result, result)
     )
   end

diff --git a/lib/absinthe/middleware/telemetry.ex b/lib/absinthe/middleware/telemetry.ex
@@ -46,7 +46,7 @@ defmodule Absinthe.Middleware.Telemetry do
 
     :telemetry.execute(
       @field_stop,
-      %{duration: end_time_mono - start_time_mono},
+      %{duration: end_time_mono - start_time_mono, end_time_mono: end_time_mono},
       %{
         id: id,
         telemetry_span_context: id,

diff --git a/lib/absinthe/phase/telemetry.ex b/lib/absinthe/phase/telemetry.ex
@@ -58,7 +58,7 @@ defmodule Absinthe.Phase.Telemetry do
     with %{id: id, start_time_mono: start_time_mono} <- blueprint.telemetry do
       :telemetry.execute(
         @subscription_stop,
-        %{duration: end_time_mono - start_time_mono},
+        %{duration: end_time_mono - start_time_mono, end_time_mono: end_time_mono},
         %{id: id, telemetry_span_context: id, blueprint: blueprint, options: options}
       )
     end
@@ -72,7 +72,7 @@ defmodule Absinthe.Phase.Telemetry do
     with %{id: id, start_time_mono: start_time_mono} <- blueprint.telemetry do
       :telemetry.execute(
         @operation_stop,
-        %{duration: end_time_mono - start_time_mono},
+        %{duration: end_time_mono - start_time_mono, end_time_mono: end_time_mono},
         %{id: id, telemetry_span_context: id, blueprint: blueprint, options: options}
       )
     end