Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TypeSystem Directives #1003

Open
binaryseed opened this issue Dec 20, 2020 · 4 comments
Open

Support TypeSystem Directives #1003

binaryseed opened this issue Dec 20, 2020 · 4 comments

Comments

@binaryseed
Copy link
Contributor

The latest GraphQL spec includes TypeSystemDirective (directives that annotate the type system) alongside the ExecutableDirective (directives that annotate query execution)

https://spec.graphql.org/draft/#TypeSystemDirectiveLocation

Absinthe has full support for ExecutableDirectives, but only partial support for TypeSystemDirectives

@kdawgwilk
Copy link
Contributor

Can I get more details on what support is missing for TypeSystemDirectives? I am looking at diving into this issue and would love any guidance.

@binaryseed
Copy link
Contributor Author

One part of this (the SDL rendering) is accomplished in this PR: #1010

I've got more working, and will submit additional PRs.

Unfortunately, I don't have much guidance since I'm figuring this out as I go, and there's probably a bit of design work with the rest of the core team to get the rest of this in place.

@binaryseed
Copy link
Contributor Author

One example of folks expecting Type System Directives to be available inside the resolver function: #964

@binaryseed
Copy link
Contributor Author

FYI, there's a comment in ^^ that includes a bit of a workaround that would enable passing directive details via meta using hydrate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants