Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL Rendering: support arbitrary schema directives #766

Closed
binaryseed opened this issue Aug 1, 2019 · 5 comments
Closed

SDL Rendering: support arbitrary schema directives #766

binaryseed opened this issue Aug 1, 2019 · 5 comments

Comments

@binaryseed
Copy link
Contributor

No description provided.

@binaryseed binaryseed self-assigned this Aug 1, 2019
@binaryseed binaryseed mentioned this issue Aug 1, 2019
@binaryseed binaryseed removed this from the Schema Definition Refactor milestone Dec 7, 2019
@jessedrelick
Copy link

I am curious if this is related to the issue I mentioned here:

#387 (comment)

@kdawgwilk
Copy link
Contributor

kdawgwilk commented Dec 16, 2020

What is actually missing to support this? I dug in a bit and it appears everything is in place to support rendering directives

directive_definitions =
directive_definitions
|> Enum.reject(&(&1.module in @skip_modules))

The only directives that are not rendered are those built-ins listed here
@skip_modules [
Absinthe.Phase.Schema.Introspection,
Absinthe.Type.BuiltIns.Directives,
Absinthe.Type.BuiltIns.Scalars,
Absinthe.Type.BuiltIns.Introspection
]

@binaryseed
Copy link
Contributor Author

This Issue isn't really the core need, I'm going to close it and create a more meaningful one

@binaryseed
Copy link
Contributor Author

#1003

@binaryseed
Copy link
Contributor Author

FYI, SDL rendering of Type System Directives was added in #1010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants