-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account for nil
schema_node in ArgumentsOfCorrectType suggestions
#1000
Account for nil
schema_node in ArgumentsOfCorrectType suggestions
#1000
Conversation
test/support/fixtures/pets_schema.ex
Outdated
@@ -123,6 +123,21 @@ defmodule Absinthe.Fixtures.PetsSchema do | |||
field :string_list_field, list_of(:string) | |||
end | |||
|
|||
scalar :custom_scalar do | |||
parse fn | |||
%Absinthe.Blueprint.Input.Object{} = input -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this part necessary to recreate the bug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not! I'll verify.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes total sense, thanks!
@binaryseed do you mind looking into these CI errors? |
some dialyzer error, pulling into a working branch to try and fix |
Ok, fixed & merged via #1001 |
When unstructured scalar input is sent in a list to a mutation argument (see example), the
schema_node
in theArgumentsOfCorrectType.suggested_field_names/2
function isnil
. I accounted for the case at the source of the error, but it is totally possible that the blueprint should account for this case and theschema_node
should be something other thannil
. I will defer to y'all's knowledge on that though.Mutation example:
Stacktrace: