Otp 25 #1252
Merged
Otp 25 #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In OTP-25 the SDL rendering was different compared to earlier versions. I traced it down to `:digraph_utils.topsort()` although could not find a relevant change in OTP-25 that would explain the difference. `topsort/1` is used to sort the nodes in the graph so that the import process can be done in the correct order in the FieldImports phase. I've changed it to no longer rely on `topsort/1`. Since the `NoCircularFieldImports` ensures there are no cycles in the graph we can use recursion for solving the imports without ending up in an endless loop. This could be less efficient. The `topsort/1` ensured that the order of imports was such that when `A` imported `B`, `B` was already imported, etc up the hierachy chain. If `C` also imported `B`, the imports for `B` would also already be done. So, `import_fields(B)` would be called once for the entire graph. Using recursion, `import_fields(B)` would be called twice, once for `A` and once for `C`. If B itself imported other fields, those would also be called multiple times. I don't think this will be a problem in practice. The cost is only incurred for schema building, and the `import_fields` graphs are probably pretty shallow. The rendering order now matches the order the type definitions were defined in.
Add support for OTP-25 and Elixir 1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.