Support deprecated input object fields in introspection query (fixes #1241) #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #1241 |
benwilson512
requested changes
Jan 4, 2024
Because `!is_deprecated || (is_deprecated && show_deprecated)` is equivalent to just `!is_deprecated || show_deprecated`
|
@benwilson512 Good callout– updated PR. There was another existing chunk following the same Thanks for creating & maintaining absinthe! It's wonderful. |
benwilson512
reviewed
Jan 5, 2024
|
@benwilson512 lmk if there are any other improvements you'd see prior to merging |
|
@benwilson512 any other changes you'd suggest prior to being able to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was setting up Apollo iOS in a new mobile app project, hoping to have it talk to my absinthe API. Apollo introspects the schema to generate types, however the introspection query wasn't processable by absinthe.
The issue was the
(includeDeprecated: true)param passed to various fields includinginputFields.The
includeDeprecatedarg for input fields was merged into the graphql spec back in Aug 2022.This PR brings absinthe up to support that arg, and makes Apollo's introspection query work.
Feedback welcome!