Fix #1302, camelize type system directives in sdl output #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelcaterisano
force-pushed
the
mc/fix-camelize-directives
branch
3 times, most recently
from
488855b to
4d769e2
Compare
michaelcaterisano
force-pushed
the
mc/fix-camelize-directives
branch
from
6768aa1 to
b77a879
Compare
| @@ -1991,7 +1991,6 @@ defmodule Absinthe.Schema.Notation do | |||
| defp default_name(Schema.DirectiveDefinition, identifier) do | |||
| identifier | |||
| |> Atom.to_string() | |||
| |> Absinthe.Utils.camelize(lower: true) | |||
There was a problem hiding this comment.
This did succeed in camelCasing the directive in the test below, but it broke a bunch of other things.
Comment on lines
-211
to
-213
| directive :foo_foo do | ||
| on :field | ||
| end |
There was a problem hiding this comment.
I thought this was a type system directive definition, but we're defining those using a prototype schema. I'm not clear on what kind of directive definition this is.
benwilson512
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1302. I camelized in one too many places and wasn't testing type system directives in the way I intended, e.g. defined in a prototype schema. This PR removes the extra call to
Absinthe.Utils.camelizeand corrects the test to use a prototype schema.cc: @benwilson512