NOISSUE - Emit non-SenML messages #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add content-type based subjects for non-senml messages to Normalizer. Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
=======================================
Coverage 90.36% 90.36%
=======================================
Files 10 10
Lines 166 166
=======================================
Hits 150 150
Misses 13 13
Partials 3 3Continue to review full report at Codecov.
|
mijicd
suggested changes
May 14, 2018
normalizer/normalizer.go
Outdated
| return err | ||
| contentType := strings.ToLower(msg.ContentType) | ||
| switch contentType { | ||
| case "application/senml+json": |
normalizer/normalizer.go
Outdated
| subject string = "channel.*" | ||
| output string = "normalized" | ||
| queue = "normalizers" | ||
| subject = "channel.*" |
normalizer/normalizer.go
Outdated
| normalized, err := ef.normalize(msg) | ||
| if err != nil { | ||
| ef.logger.Warn(fmt.Sprintf("Normalization failed: %s", err)) | ||
| return err | ||
| contentType := strings.ToLower(msg.ContentType) |
There was a problem hiding this comment.
Please replace with:
switch ct := strings.ToLower(msg.ContentType); ct {
...
}Signed-off-by: Aleksandar Novakovic <aleksandar.novakovic@mainflux.com>
mijicd
approved these changes
May 14, 2018
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
dborovcanin
pushed a commit
that referenced
this pull request
Jan 26, 2024
Signed-off-by: Arvindh <arvindh91@gmail.com>
VeddySama
pushed a commit
to VeddySama/magistrala
that referenced
this pull request
Apr 3, 2024
Signed-off-by: Arvindh <arvindh91@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves #239.
Add
out.[content-type]subjects for non-senml messages to NATS. If content type is unknown, message will be published onout.unknown.