Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Fix CI to fetch tags #2282

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Conversation

dborovcanin
Copy link
Collaborator

What type of PR is this?

This is a quick fix of CI scirpt.

What does this do?

Since our code build includes the latest Git tag for the Health endpoint, we need to have at least the latest tag available during building binaries in the CI.

Which issue(s) does this PR fix/relate to?

There is no such issue.

Have you included tests for your changes?

N/A

Did you document any new/modified feature?

N/A

Notes

N/A

arvindh123
arvindh123 previously approved these changes Jun 10, 2024
@dborovcanin
Copy link
Collaborator Author

Unfortunately, fetching tags on this action is still broken: actions/checkout#1471. I had to add a manual step for that.

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/tests.yml Outdated Show resolved Hide resolved
@dborovcanin dborovcanin force-pushed the fix-ci-tag branch 4 times, most recently from 85dba22 to b21262a Compare June 11, 2024 09:55
Makefile Outdated Show resolved Hide resolved
Copy link
Member

@rodneyosodo rodneyosodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Dusan Borovcanin <borovcanindusan1@gmail.com>
Signed-off-by: Dusan Borovcanin <borovcanindusan1@gmail.com>
Signed-off-by: Dusan Borovcanin <borovcanindusan1@gmail.com>
Signed-off-by: Dusan Borovcanin <borovcanindusan1@gmail.com>
@dborovcanin dborovcanin merged commit cb00f3a into absmach:main Jun 11, 2024
4 checks passed
@dborovcanin dborovcanin deleted the fix-ci-tag branch June 11, 2024 10:12
andychao217 pushed a commit to andychao217/magistrala that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants