SMQ-2605: Groups replication with groups events consumer & listing of things and channels #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvindh123
force-pushed
the
consume_groups_events
branch
from
ca260c1 to
7d8c494
Compare
ianmuchyri
requested changes
Jan 9, 2025
clients/clients.go
Outdated
| @@ -35,6 +35,9 @@ type Repository interface { | |||
| // RetrieveAll retrieves all clients. | |||
| RetrieveAll(ctx context.Context, pm Page) (ClientsPage, error) | |||
|
|
|||
| // RetrieveUserThings retrieve all clients of a given user id. | |||
| RetrieveUserThings(ctx context.Context, domainID, userID string, pm Page) (ClientsPage, error) | |||
There was a problem hiding this comment.
shouldn't this be RetrieveUserClients ?
clients/service.go
Outdated
|
|
||
| if err := g.Wait(); err != nil { | ||
| return ClientsPage{}, err | ||
| cp, err := svc.repo.RetrieveUserThings(ctx, session.DomainID, session.UserID, pm) |
There was a problem hiding this comment.
same here ? svc.repo.RetrieveUserClients
arvindh123
changed the title
arvindh123
force-pushed
the
consume_groups_events
branch
10 times, most recently
from
cf2879d to
095e611
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2639 +/- ##
==========================================
- Coverage 45.24% 40.38% -4.87%
==========================================
Files 346 230 -116
Lines 44515 34148 -10367
==========================================
- Hits 20142 13790 -6352
+ Misses 22180 19297 -2883
+ Partials 2193 1061 -1132 ☔ View full report in Codecov by Sentry. |
|
@arvindh123 Please rebase. |
arvindh123
force-pushed
the
consume_groups_events
branch
from
d5f1d88 to
577b0a1
Compare
arvindh123
force-pushed
the
consume_groups_events
branch
from
577b0a1 to
11c92fe
Compare
|
@arvindh123 Please address linter remarks. |
arvindh123
force-pushed
the
consume_groups_events
branch
from
11c92fe to
2b2c4bb
Compare
dborovcanin
force-pushed
the
consume_groups_events
branch
from
2b2c4bb to
9c958e8
Compare
Signed-off-by: Arvindh <arvindh91@gmail.com>
Signed-off-by: Arvindh <arvindh91@gmail.com>
Signed-off-by: Arvindh <arvindh91@gmail.com>
Signed-off-by: Arvindh <arvindh91@gmail.com>
Signed-off-by: Arvindh <arvindh91@gmail.com>
Signed-off-by: Arvindh <arvindh91@gmail.com>
Signed-off-by: Arvindh <arvindh91@gmail.com>
dborovcanin
force-pushed
the
consume_groups_events
branch
from
9c958e8 to
72309b1
Compare
dborovcanin
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it adds the following functionality:
What does this do?
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified feature?
Notes