Skip to content

Commit

Permalink
depends: make osx output deterministic
Browse files Browse the repository at this point in the history
ld64 is threaded, and uses a worker for each CPU to parse input files. But
there's a bug in the parser causing dependencies to be calculated differently
based on which files have already been parsed.

As a result, builders with more CPUs are more likely to see non-determinism.

This looks to have been fixed in a newer version of ld64, so just disable
threading for now. There's no noticible slowdown.
  • Loading branch information
theuni committed Mar 1, 2017
1 parent 7e2a221 commit 9e4d842
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion depends/packages/native_cctools.mk
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ $(package)_cxx=$($(package)_extract_dir)/toolchain/bin/clang++
endef

define $(package)_preprocess_cmds
cd $($(package)_build_subdir); ./autogen.sh
cd $($(package)_build_subdir); ./autogen.sh && \
sed -i.old "/define HAVE_PTHREADS/d" ld64/src/ld/InputFiles.h
endef

define $(package)_config_cmds
Expand Down

0 comments on commit 9e4d842

Please sign in to comment.